Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show tooltips on hover for type property definitions and type additional properties accesses #13546

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

jeskew
Copy link
Contributor

@jeskew jeskew commented Mar 7, 2024

Resolves #13461
Resolves #13398

There were a couple of scenarios where the LS was not showing hover tooltips for properties:

  • When hovering over a type property definition
  • When hovering over a property name that would match against a value's additional properties type

There's no way to capture a description for an object's additional properties type, but the hover can at least show the expected type.

@jeskew jeskew requested a review from a team March 7, 2024 20:04
Copy link
Contributor

github-actions bot commented Mar 7, 2024

Test this change out locally with the following install scripts (Action run 8236778201)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 8236778201
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 8236778201"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 8236778201
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 8236778201"

Copy link
Contributor

github-actions bot commented Mar 7, 2024

Test Results

    66 files   -     33      66 suites   - 33   22m 14s ⏱️ - 24m 42s
10 679 tests  -     18  10 677 ✅  -     18  2 💤 ±0  0 ❌ ±0 
25 248 runs   - 12 614  25 244 ✅  - 12 612  4 💤  - 2  0 ❌ ±0 

Results for commit ee2931a. ± Comparison against base commit 5880dee.

♻️ This comment has been updated with latest results.

@jeskew jeskew closed this Mar 8, 2024
@jeskew jeskew reopened this Mar 8, 2024
Copy link
Contributor

@shenglol shenglol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants